[NL] Disable llm fallback for entity based queries. #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chejennifer
approved these changes
Nov 8, 2024
| @@ -122,6 +126,10 @@ def _has_no_entity(d: Detection) -> bool: | |||
| return not d.places_detected or not d.places_detected.entities_found | |||
|
|
|||
|
|
|||
| def _has_entity(d: Detection) -> bool: | |||
There was a problem hiding this comment.
nit: I don't think we need this helper since there's not really any logic here
There was a problem hiding this comment.
The double negative is a little rough for readability -- I updated the code to only have _has_entity to avoid this issue. Is that okay?
There was a problem hiding this comment.
I'll merge this for now so that the logic is in autopush. I can change the readability part if you prefer the _has_no_entity with the double negative as a follow up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling the LLM fallback for entity based queries for now since the prompt is tailored to place+statvar queries.