-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bio] Update biomed property embeddings. #4721
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4418038
[NL] Update biomed property embeddings.
clincoln8 af6fb0b
Merge branch 'datacommonsorg:master' into bio-embeddings
clincoln8 60628a6
Merge branch 'master' of github.com:clincoln8/datcom-website into bio…
clincoln8 ad48223
Update golden cosine scores for new embeddings.
clincoln8 5ffd1e6
Update bio integration tests to request genomic coordinates instead o…
clincoln8 9c12fcf
Fix embedding nits
clincoln8 7fc1001
Merge branch 'master' of https://github.com/datacommonsorg/website in…
clincoln8 3228d0d
Update goldens.
clincoln8 1a32ea1
Fix trailing whitespace
clincoln8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 7 additions & 45 deletions
52
server/integration_tests/test_data/e2e_triple/whattranscriptsdoesithave/chart_config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,53 +1,15 @@ | ||
{ | ||
"client": "test_detect-and-fulfill", | ||
"config": { | ||
"categories": [ | ||
{ | ||
"blocks": [ | ||
{ | ||
"columns": [ | ||
{ | ||
"tiles": [ | ||
{ | ||
"entities": [ | ||
"bio/FGFR1" | ||
], | ||
"type": "ENTITY_OVERVIEW" | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
}, | ||
"config": {}, | ||
"context": {}, | ||
"debug": {}, | ||
"entities": [ | ||
{ | ||
"dcid": "bio/FGFR1", | ||
"name": "FGFR1", | ||
"type": "" | ||
} | ||
], | ||
"pastSourceContext": "", | ||
"place": {}, | ||
"placeFallback": {}, | ||
"placeSource": "UNKNOWN", | ||
"places": [], | ||
"relatedThings": { | ||
"childPlaces": {}, | ||
"childTopics": [], | ||
"exploreMore": {}, | ||
"mainTopics": [], | ||
"parentPlaces": [], | ||
"parentTopics": [], | ||
"peerPlaces": [], | ||
"peerTopics": [] | ||
"failure": "Sorry, could not complete your request. No entity found in the query.", | ||
"place": { | ||
"dcid": "", | ||
"name": "", | ||
"place_type": "" | ||
}, | ||
"svSource": "UNKNOWN", | ||
"userMessages": [ | ||
"See relevant information for FGFR1 based on the previous query." | ||
"Sorry, could not complete your request. No entity found in the query." | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chejennifer I'm not sure why we're seeing this diff. I'm removing the
hasRNATranscript
property which is related to the query, but I don't know why it's affecting entity recognition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, the reason for this is we used to be reading the entity from the context (from the previous query), but we will only read from context if at least one of entity or property is detected in the current query. Since now, no property is detected, we won't use the context and no entity gets returned. We actually should remove this query from the tests since this isn't really testing anything anymore