Improvements to header #4709
Merged
Improvements to header #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnoble
approved these changes
Nov 7, 2024
nick-next
force-pushed
the
custom-header-fix
branch
from
de7f53a to
1f39c3c
Compare
nick-next
force-pushed
the
custom-header-fix
branch
from
1f39c3c to
c661948
Compare
gmechali
pushed a commit
to gmechali/website
that referenced
this pull request
Nov 21, 2024
## Description This PR follows up from previous changes to the autocomplete, in order to fix the margins around the box in some views. The header search bar now displays in the correct place in all views, including with the autocomplete. Some additional refactoring of the styles was done, including the beginning of a more complete separation of the new home page styles from the template custom styles. As an example of one of the adjustments: Before:  After: <img width="560" alt="Screenshot 2024-11-04 at 8 01 06 PM" src="https://github.com/user-attachments/assets/0057a7e3-a083-4525-9b07-2ce23acefa9c"> --------- Co-authored-by: Pablo Noel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows up from previous changes to the autocomplete, in order to fix the margins around the box in some views.
The header search bar now displays in the correct place in all views, including with the autocomplete.
Some additional refactoring of the styles was done, including the beginning of a more complete separation of the new home page styles from the template custom styles.
As an example of one of the adjustments:
Before:
After: