Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve multi-sv query combination computation #2522

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Improve multi-sv query combination computation #2522

merged 4 commits into from
Mar 31, 2023

Conversation

pradh
Copy link
Contributor

@pradh pradh commented Mar 31, 2023 •
edited
Loading

Fold in the great feedback from @jehangiramjad on #2510.

This also fixes a bug in previous implementation.

@pradh pradh requested a review from jehangiramjad March 31, 2023 01:40
jehangiramjad
jehangiramjad approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@jehangiramjad jehangiramjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@pradh
Copy link
Contributor Author

pradh commented Mar 31, 2023

Thanks for the review!

@pradh pradh merged commit 2bcd7ef into datacommonsorg:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jehangiramjad jehangiramjad jehangiramjad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradh @jehangiramjad