Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NL: Detect multiple SVs in a query #2397

Closed
pradh opened this issue Mar 8, 2023 · 0 comments
Closed

NL: Detect multiple SVs in a query #2397

pradh opened this issue Mar 8, 2023 · 0 comments
Assignees
@pradh
Labels
nl Issues dealing with the Data Commons NL interface

Comments

@pradh
Copy link
Contributor

pradh commented Mar 8, 2023

To support queries like [prevalence of asthma vs. temperature rise across california]
@pradh pradh added the nl Issues dealing with the Data Commons NL interface label Mar 8, 2023
@pradh pradh self-assigned this Mar 9, 2023
@pradh pradh mentioned this issue Mar 29, 2023
Merged
pradh added a commit that referenced this issue Mar 30, 2023
@pradh
Implement multi-sv detection (#2510)
f84c7c1 
Roughly as described in [this
doc](https://docs.google.com/document/d/1BBQabxodKdDZON7b8Sc_C49in-AZ2LTUkPzXoHZLQjs/edit?pli=1&resourcekey=0-AYbBt44Dh7S1OQOm8ztYNA#heading=h.v6k65row53ow).
Not hooked up to fulfillment yet. Propagated to debug info (screenshot
below).

This PR moves the stop-word removal done for single-sv detection from
website server to nl server. This is so that multi-sv detection can be
done with the stop-words present.

BUG=#2397


![image](https://user-images.githubusercontent.com/4375037/228465867-5a236ea1-46bd-4a4b-84b2-ac90397098fc.png)
@pradh pradh mentioned this issue Apr 6, 2023
Merged
pradh added a commit that referenced this issue Apr 6, 2023
@pradh
NL: Implement multi-sv fulfillment for correlation (#2547)
2623863 
Generally, try to be conservative in fulfilling multi-sv, so we fulfill
multi-sv to show correlations only when:
1. There's a COMPARISON or CORRELATION attribute detected (words like
`compare`, `vs`, etc.)
2. The aggregate multi-sv score exceeds the max single-sv score

Additional changes:
* Promote a SIMPLE query with multiple places to
COMPARISON_ACROSS_PLACES.
* If a correlation query doesn't have a place-type, use DEFAULT_TYPE
* In COMPARISON_ACROSS_PLACES, if we find the current utterance has
multiple places, don't bother continuing into the context
* Add unit and integration tests

Related bugs: #2397,
#2515

Screenshot:


![image](https://user-images.githubusercontent.com/4375037/230257737-d77b6dcd-3e75-46d0-a4ff-6b63c699107e.png)
@pradh pradh closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pradh pradh

Labels
nl Issues dealing with the Data Commons NL interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pradh