-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Schema.org link to sidebar #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilimAnnejaro/docsite into dataset-contrib-change-content
Hi @KilimAnnejaro could you update this PR with the master branch, I'll take a look then. Thank you! |
@tjann done! |
tjann
approved these changes
Sep 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @tjann, I'm trying to migrate the content from https://github.com/datacommonsorg/data/tree/master/docs into links in the main docs repo. Most of that migration is in #63; this PR incorporates the Schema.org link from that page into the side navbar.
This PR is fundamentally a bit of a stopgap measure for two reasons:
If you think it would be better to wait until I can restructure navigation to incorporate this link, feel free to close this PR; however, if it would be beneficial to incorporate the schema.org link into the link structure quickly (along with the rest of the content from https://github.com/datacommonsorg/data/tree/master/docs), then this PR will be useful.