Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Schema.org link to sidebar #65

Merged
merged 15 commits into from
Sep 18, 2020
Merged

Adding Schema.org link to sidebar #65

merged 15 commits into from
Sep 18, 2020

Conversation

KilimAnnejaro
Copy link
Collaborator

Per discussion with @tjann, I'm trying to migrate the content from https://github.com/datacommonsorg/data/tree/master/docs into links in the main docs repo. Most of that migration is in #63; this PR incorporates the Schema.org link from that page into the side navbar.
This PR is fundamentally a bit of a stopgap measure for two reasons:

  1. I think that the entire structure of having a redirect page for this functionality is a bit weird. However, adding a link to the sidebar is non-trivial at this time--we will probably need a navigation.yaml to make that easier.
  2. I dislike the lack of annotation for leaving Data Commons, and would like to model the link styling along the lines of https://www.isomer.gov.sg/ and its source https://github.com/isomerpages/isomerpages-isomergovsg.
    If you think it would be better to wait until I can restructure navigation to incorporate this link, feel free to close this PR; however, if it would be beneficial to incorporate the schema.org link into the link structure quickly (along with the rest of the content from https://github.com/datacommonsorg/data/tree/master/docs), then this PR will be useful.

@tjann
Copy link
Contributor

tjann commented Sep 17, 2020

Hi @KilimAnnejaro could you update this PR with the master branch, I'll take a look then. Thank you!

@KilimAnnejaro
Copy link
Collaborator Author

@tjann done!

Copy link
Contributor

@tjann tjann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@tjann tjann merged commit a9dc04e into datacommonsorg:master Sep 18, 2020
@KilimAnnejaro KilimAnnejaro deleted the redirect branch September 18, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants