New procedure for syncing to stable release #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though the style guide says to just use imperatives, "get started" just sounds weird. Also this is more consistent with "troubleshooting"
hqpho
reviewed
Nov 7, 2024
hqpho
reviewed
Nov 7, 2024
|
Thanks for putting this together! I think probably once we get feedback from partners on how exactly they are using the branch, we might want to update this to also include how to pull in new changes from the branch. And we might want to recommend an approach that involves a fork by default. But for now this is good enough to get people started! |
|
OK, try reviewing again now.
…On Thu, Nov 7, 2024 at 1:00 PM Hannah Pho ***@***.***> wrote:
Thanks for putting this together! I think probably once we get feedback
from partners on how exactly they are using the branch, we might want to
update this to also include how to pull in new changes from the branch. And
we might want to recommend an approach that involves a fork by default. But
for now this is good enough to get people started!
—
Reply to this email directly, view it on GitHub
<#536 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHMM7UB7MW7RLYKM2EQDS6TZ7PIFLAVCNFSM6AAAAABRL55GPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTGIYDGNJXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
hqpho
reviewed
Nov 11, 2024
hqpho
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better Github procedure suggestions welcome!
Staged at bullie.svl.corp.google.com:4000