Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback from one.org et. al. #532

Merged
merged 174 commits into from
Nov 5, 2024
Merged

Address feedback from one.org et. al. #532

merged 174 commits into from
Nov 5, 2024

Conversation

kmoscoe
Copy link
Contributor

@kmoscoe kmoscoe commented Nov 4, 2024

No description provided.

kmoscoe and others added 30 commits July 11, 2024 13:23
@kmoscoe
integrate custom docs with new UI
6af1ba7
@kmoscoe
more edits
cd0fe76
@kmoscoe
use website wording for intro
c45d61b
@kmoscoe
fix numbering in table
f5cbbca
@kmoscoe
Merge branch 'master' into custom_dc
90c57e7
@kmoscoe
rename and some edits
57ca62f
@kmoscoe
Merge branch 'custom_dc' of https://github.com/kmoscoe/docsite into c…
2277cb1 
…ustom_dc
@kmoscoe
rename manage_repo file, per Bo
fb33722
@kmoscoe
Merge.
0ebdd67
@kmoscoe
merge
e3148c4
@kmoscoe
Merge branch 'datacommonsorg:master' into master
ee5f580
@kmoscoe
Merge branch 'master' of https://github.com/datacommonsorg/docsite
5993fb7
@kmoscoe
Merge branch 'custom_dc'
61ce06d
@kmoscoe
Merge branch 'datacommonsorg:master' into master
2b37137
@kmoscoe
formatting edits
37f3e87
@kmoscoe
updates per Keyur's feedback
d83db88
@kmoscoe
Fix typos
03b906f
@kmoscoe
fix nav order
03538af
@kmoscoe
fix link to API key request form
d7fb58f
@kmoscoe
update form link
c746a7e
@kmoscoe
update key request form and output dir env var
d5e04af
@kmoscoe
Merge branch 'master' into custom_dc
0183130
@kmoscoe
Revert to gerund
b6f53cf 
Though the style guide says to just use imperatives, "get started" just sounds weird. Also this is more consistent with "troubleshooting"
@kmoscoe
Merge branch 'master' into master
e538860
@kmoscoe
new troubleshooting entry
d368ba4
@kmoscoe
Merge branch 'datacommonsorg:master' into master
db99da0
@kmoscoe
Merge branch 'custom_dc' of https://github.com/kmoscoe/docsite into c…
535962c 
…ustom_dc
@kmoscoe
Merge branch 'master' of https://github.com/kmoscoe/docsite into cust…
fd071e9 
…om_dc
@kmoscoe
fix typo
771ccca
@kmoscoe
Merge branch 'datacommonsorg:master' into master
7f2bccf
kmoscoe and others added 16 commits October 9, 2024 14:32
@kmoscoe
Merge branch 'master' of https://github.com/kmoscoe/docsite into cust…
af35c2d 
…om_dc
@kmoscoe
more edits
39de516
@kmoscoe
corrections from Keyur
e206c7f
@kmoscoe
one more change from Keyur
b066852
@kmoscoe
Merge branch 'datacommonsorg:master' into master
088e3f9
@kmoscoe
Merge branch 'datacommonsorg:master' into custom_dc
9fa99fd
@kmoscoe
Add update schema option.
2740f0d
@kmoscoe
Merge branch 'master' of https://github.com/kmoscoe/docsite into cust…
7b0de60 
…om_dc
@kmoscoe
Merge branch 'custom_dc' of https://github.com/kmoscoe/docsite into c…
61bc24c 
…ustom_dc
@kmoscoe
wording fixes
f765cf1
@kmoscoe
add CLI procedures
1dc0f90
@kmoscoe
Merge branch 'datacommonsorg:master' into master
38fc2b9
@kmoscoe
Merge branch 'master' of https://github.com/kmoscoe/docsite into cust…
c2c3a3e 
…om_dc
@kmoscoe
fix troubleshooting doc
230def4
@kmoscoe
fix custom data
ce2b42c
@kmoscoe
fix troubleshooting again
eee5569
@kmoscoe kmoscoe requested review from keyurva and dwnoble November 4, 2024 23:16
@kmoscoe kmoscoe marked this pull request as draft November 4, 2024 23:38
@kmoscoe kmoscoe removed request for dwnoble and keyurva November 4, 2024 23:38
@kmoscoe kmoscoe changed the title Add CLI procedures for repetitive GCP tasks Address feedback from one.org et. al. Nov 5, 2024
@kmoscoe
Copy link
Contributor Author

kmoscoe commented Nov 5, 2024

This PR addresses all the feedback from one.org, pending the automatic triggering of job restarts:

  1. Adds command-line equivalents for all repetitive procedures
  2. Adds a section on storing secrets in Secret Manager and updates screenshots for that
  3. Removes incorrect cost estimate

Staged at bullie.svl.corp.google.com:4000

In a future PR, will convert the CLI/Console procedures to tab-based.

@kmoscoe kmoscoe marked this pull request as ready for review November 5, 2024 19:20
@kmoscoe kmoscoe requested review from keyurva and dwnoble November 5, 2024 19:20
@kmoscoe kmoscoe merged commit 2ad5474 into datacommonsorg:master Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnoble dwnoble dwnoble approved these changes

@keyurva keyurva Awaiting requested review from keyurva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmoscoe @dwnoble