Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few custom dc fixes #514

Merged
merged 6 commits into from
Sep 24, 2024
Merged

A few custom dc fixes #514

merged 6 commits into from
Sep 24, 2024

Conversation

beets
Copy link
Contributor

@beets beets commented Sep 20, 2024

  • Fix a broken link
  • Update footer to match main dc site

@beets beets requested a review from kmoscoe September 20, 2024 20:59
@@ -159,7 +159,7 @@ This does the following:
- Maps the input sample data to a Docker path.
- Starts a Docker container.
- Imports the data from the CSV files, resolves entities, and writes the data to a SQLite database file, `custom_dc/sample/datacommons/datacommons.db`.
- Generates embeddings in `custom_dc/sample/datacommons/nl`. (To learn more about embeddings generation, see the [FAQ](faq.md#natural-language-processing).
- Generates embeddings in `custom_dc/sample/datacommons/nl`. (To learn more about embeddings generation, see the [FAQ](faq.html#natural-language-processing)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need an absolute link for this to work, i.e. /custom_dc/faq...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - will update

Copy link
Contributor

@kmoscoe kmoscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@beets beets merged commit 5e2b45f into datacommonsorg:master Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants