Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback link to the default layout #499

Merged
merged 56 commits into from
Sep 9, 2024

Conversation

kmoscoe
Copy link
Contributor

@kmoscoe kmoscoe commented Sep 4, 2024

This adds a link to the feedback form that will appear on all doc pages in the Docsite. Looking for styling improvements!

Staged at bullie.svl.corp.google.com:4000

kmoscoe and others added 30 commits July 24, 2024 15:20
Though the style guide says to just use imperatives, "get started" just sounds weird. Also this is more consistent with "troubleshooting"
This reverts commit d35bc34.
@kmoscoe kmoscoe changed the title Feedback Add feedback link to the default layout Sep 4, 2024
@kmoscoe kmoscoe requested review from beets and miss-o-soup September 4, 2024 21:39
Copy link
Contributor

@beets beets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - let's push it and test it out.

@kmoscoe kmoscoe merged commit d706e29 into datacommonsorg:master Sep 9, 2024
1 check passed
@kmoscoe kmoscoe deleted the feedback branch September 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants