Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated info in Sheets landing page #477

Merged
merged 25 commits into from
Aug 16, 2024

Conversation

kmoscoe
Copy link
Contributor

@kmoscoe kmoscoe commented Aug 15, 2024

This PR does the following to remove very old, outdated info:

  • Fixes egregiously outdated and incorrect info (like limitations on U.S. places only, missing parameter names, formulas with typos that don't work)
  • Removes the video, which shows an old UI that has changed
  • Removes info on how to sort multiple columns, which is a Sheets feature, not a DC one
  • Turns the restatement of the video into an actual procedure
  • Refactors redundant info in the "enable" and "find DCIDs" sections

It also:

  • Adds a mention of the Find place ID feature to the key concepts doc
  • Removes the "find DCID" info from the glossary and points to the key concepts doc instead

Staged at bullie.svl.corp.google.com:4000

@kmoscoe kmoscoe requested review from juliawu, premr and clincoln8 August 15, 2024 17:58
Copy link
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


The **Data Commons Sheets API** is a Google Sheets add-on that enables Google Sheets users to import data from the Data Commons knowledge graph. The add-on provides an interface for finding a location’s unique Data Commons identifier ([DCID](glossary.html#dcid)), and some custom functions for importing data into a spreadsheet.
The Data Commons Sheets is a Google Sheets add-on that allows you to import data from the Data Commons knowledge graph. The add-on provides an interface for finding a location’s unique Data Commons identifier ([DCID](glossary.html#dcid)), and several custom functions for importing data into a spreadsheet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's repetitive, but should the first sentence start with "The Data Commons Sheets add-on is a..."? Otherwise it sounds like we have a product called "Data Commons Sheets"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch. Fixed.

@kmoscoe kmoscoe merged commit 1f99989 into datacommonsorg:master Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants