Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API intro pages refactor #458

Merged
merged 75 commits into from
Aug 1, 2024
Merged

Conversation

kmoscoe
Copy link
Contributor

@kmoscoe kmoscoe commented Jul 24, 2024

Refactor the index and getting started pages as follows:

  • Move API key request process and other generalities to index page and focus getting started on assembling requests
  • Move relation expressions to assembling requests
  • Move out troubleshooting to a separate page
  • Combine info about end points
  • Add a note about escape codes
  • Edit for clarity
  • Use style guide formatting

Partly previously reviewed by Bo.

Staged at bullie.svl.corp.google.com

@kmoscoe kmoscoe requested a review from chejennifer July 24, 2024 20:28
kmoscoe and others added 6 commits July 24, 2024 13:35
Though the style guide says to just use imperatives, "get started" just sounds weird. Also this is more consistent with "troubleshooting"
@chejennifer
Copy link
Contributor

hm, I'm getting a server error when trying to access http://bullie.svl.corp.google.com/: https://screenshot.googleplex.com/4EjKdibwstn9CFb

@kmoscoe
Copy link
Contributor Author

kmoscoe commented Jul 29, 2024 via email

@chejennifer
Copy link
Contributor

Try now.

On Mon, Jul 29, 2024 at 9:12 AM chejennifer @.> wrote: hm, I'm getting a server error when trying to access http://bullie.svl.corp.google.com/: https://screenshot.googleplex.com/4EjKdibwstn9CFb — Reply to this email directly, view it on GitHub <#458 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHMM7UFWSA7FEKDGKECTOYLZOZSW3AVCNFSM6AAAAABLNGRLZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGM2DKNBXGI . You are receiving this because you authored the thread.Message ID: @.>

still getting the same server error

@kmoscoe
Copy link
Contributor Author

kmoscoe commented Jul 29, 2024 via email

@chejennifer
Copy link
Contributor

bullie.svl.corp.google.com

ah, did not use port 4000, I just copy pasted the link in the description

@kmoscoe
Copy link
Contributor Author

kmoscoe commented Jul 29, 2024 via email

Copy link
Contributor

@chejennifer chejennifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

api/rest/v2/getting_started.md Outdated Show resolved Hide resolved
api/rest/v2/getting_started.md Outdated Show resolved Hide resolved
api/rest/v2/getting_started.md Outdated Show resolved Hide resolved
api/rest/v2/getting_started.md Outdated Show resolved Hide resolved
api/rest/v2/index.md Outdated Show resolved Hide resolved
}
```

This is most commonly seen when your request is missing a required path parameter. Make sure endpoints and parameters are both spelled correctly and provided in the right order.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious what the difference between this and "method does not exist is"? reading the descriptions of the two, it seems like both have to do with path parameters being incorrect? maybe should make clear the difference between the two error messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't know. I'll need to check the code and update this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I'm looking in the right place, it seems like "invalid request URI" is about a parameter being "missing" (i.e. there are fewer than 2 parameters in the URI string): https://github.com/search?q=repo%3Adatacommonsorg%2Fmixer%20%22Invalid%20request%20URI%22&type=code

But I can't actually find anything about "Method does not exist." Maybe I should just remove that one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like "invalid request URI" only appears for v1 endpoints? https://screenshot.googleplex.com/6H4sFJixiuWBtjX

have you seen this error when working with v2 endpoints?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, looks like this is indeed to v1, and the doc wasn't updated. I had assumed that v2 just inherited the v1 errors, but it appears not: https://github.com/search?q=repo%3Adatacommonsorg%2Fmixer+path%3A%2F%5Einternal%5C%2Fserver%5C%2Fv2%5C%2F%2F+errorf&type=code I suspect that one of the big improvements in v2 was more meaningful error messages in fact. :-) The only ones I can reproduce easily are empty data and "marshalling errors". For now, I'll just remove these two, though I wonder if maybe we don't actually need a troubleshooting page altogether...

api/rest/v2/troubleshooting.md Outdated Show resolved Hide resolved
@kmoscoe kmoscoe requested a review from chejennifer July 31, 2024 21:57
Copy link
Contributor

@chejennifer chejennifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating!

@kmoscoe kmoscoe merged commit 0c81351 into datacommonsorg:master Aug 1, 2024
1 check passed
@kmoscoe kmoscoe deleted the api_docs_overhaul branch November 7, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants