Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built jekyll theme for docs #43

Merged
merged 6 commits into from
Jul 20, 2020
Merged

Built jekyll theme for docs #43

merged 6 commits into from
Jul 20, 2020

Conversation

beets
Copy link
Contributor

@beets beets commented Jul 19, 2020

Update styles to match datacommons.org

@beets beets requested review from tjann, mvashishtha and shifucun and removed request for mvashishtha July 19, 2020 23:12
Copy link
Contributor

@tjann tjann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pro now!

@beets
Copy link
Contributor Author

beets commented Jul 19, 2020

Thanks! We can enforce https after this is in, since we don't load external sources anymore.

@shifucun
Copy link
Contributor

this is very cool! Is there a way to reference the bootstrap css from somewhere? In current way, might need some license headers in those files? There might be some requirement for included 3rd party code: go/patching#license-headers-and-copyright-notices

@beets
Copy link
Contributor Author

beets commented Jul 20, 2020

Yea, good point. Will add that in a follow up. There doesn't seem to be a good way of including it another way while still letting github pages to compile and deploy the pages (other methods require local builds and deploying that instead)

@beets beets merged commit 71fc713 into datacommonsorg:master Jul 20, 2020
# in the templates via {{ site.myvariable }}.
title: "Data Commons Docs"
description: Data Commons Documentation
url: "https://docs.dataacommons.org"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beets I think this typo breaks some links, e.g. the one to "Statistical Variables" on this page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. Fixed in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants