-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Built jekyll theme for docs #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pro now!
Thanks! We can enforce https after this is in, since we don't load external sources anymore. |
this is very cool! Is there a way to reference the bootstrap css from somewhere? In current way, might need some license headers in those files? There might be some requirement for included 3rd party code: go/patching#license-headers-and-copyright-notices |
Yea, good point. Will add that in a follow up. There doesn't seem to be a good way of including it another way while still letting github pages to compile and deploy the pages (other methods require local builds and deploying that instead) |
# in the templates via {{ site.myvariable }}. | ||
title: "Data Commons Docs" | ||
description: Data Commons Documentation | ||
url: "https://docs.dataacommons.org" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out. Fixed in #46
Update styles to match datacommons.org