-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added plugin support for relative links and make fixes/updates to other .md files #405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates!
Could you also please add more context to the PR description?
thanks for the update. i think you need to push your changes to your remote branch. for this and future PR's, please add the "why" for the change to the PR description. |
Actually, there's a couple of other changes I need to make. Is there a way
to add more info to the PR description? I couldn't figure it out.
…On Mon, May 20, 2024 at 2:59 PM Carolyn Au ***@***.***> wrote:
thanks for the update. i think you need to push your changes to your
remote branch.
for this and future PR's, please add the "why" for the change to the PR
description.
—
Reply to this email directly, view it on GitHub
<#405 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHMM7UDQM6FO5OVQOEUJZR3ZDJW35AVCNFSM6AAAAABIAIAJLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRGI4DEOJTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Like, for example, in Critique, you have a CL title and a CL description; I
can't figure out how to add a longer description.
…On Mon, May 20, 2024 at 3:23 PM Kara Moscoe ***@***.***> wrote:
Actually, there's a couple of other changes I need to make. Is there a way
to add more info to the PR description? I couldn't figure it out.
On Mon, May 20, 2024 at 2:59 PM Carolyn Au ***@***.***>
wrote:
> thanks for the update. i think you need to push your changes to your
> remote branch.
>
> for this and future PR's, please add the "why" for the change to the PR
> description.
>
> —
> Reply to this email directly, view it on GitHub
> <#405 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BHMM7UDQM6FO5OVQOEUJZR3ZDJW35AVCNFSM6AAAAABIAIAJLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRGI4DEOJTHA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fixes!
This change adds support for a relative links plug-in (https://github.com/benbalter/jekyll-relative-links/blob/main/README.md), which otherwise don't work in Github Pages sites.
In addition, made the following changes to the readme files: