[WDI Indicator Download] Provide a default filename for WDI download #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaits
approved these changes
Feb 12, 2024
shamimansari1988
pushed a commit
to shamimansari1988/data
that referenced
this pull request
Aug 12, 2024
…atacommonsorg#982) * Provide a default filename for WDI download * Adding a helpful print statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During import automation testing, noticed that the script linked in the manifest expects a FLAG which is a path on CNS. That won't work for import automation so now adding a default filename to write the output to (locally). This output is then deposited to the correct GCS bucket.
Tested using the local import automation update script and with this fix it works.