Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frozendict from us_fed script #972

Merged
merged 12 commits into from
Jan 31, 2024
Merged

Remove frozendict from us_fed script #972

merged 12 commits into from
Jan 31, 2024

Conversation

ajaits
Copy link
Contributor

@ajaits ajaits commented Jan 31, 2024

Remove frozendict import as it generates an error in python 3.11:

Traceback (most recent call last):
  File "/usr/local/google/dc/refresh/git_us_usda/data/scripts/us_fed/treasury_constant_maturity_rates/generate_csv_and_mcf.py", line 31, in <module>
    from frozendict import frozendict
  File "/google/src/cloud/ajaits/dc-github/google3/env_py_3_11/lib/python3.11/site-packages/frozendict/__init__.py", line 16, in <module>
    class frozendict(collections.Mapping):
                     ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'collections' has no attribute 'Mapping'

@ajaits ajaits requested a review from jehangiramjad January 31, 2024 08:20
jehangiramjad
jehangiramjad approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@jehangiramjad jehangiramjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jehangiramjad jehangiramjad merged commit 9b0a244 into datacommonsorg:master Jan 31, 2024
8 of 9 checks passed
shamimansari1988 pushed a commit to shamimansari1988/data that referenced this pull request Aug 12, 2024
@ajaits
Remove frozendict from us_fed script (datacommonsorg#972)
2e8ebbd 
* set defaults to single year, limited counties to temporarily have script finish in <1 for autorefresh test

* lint fix

* lint fix

* set user-agent for downloads

* set user-agent for downloads

* fix script for input format change

* remove header rows

* remove frozendict as it is not supported in 3.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jehangiramjad jehangiramjad jehangiramjad approved these changes

Assignees

@shifucun shifucun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajaits @jehangiramjad @shifucun