Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import automation: Setup script updates #966

Merged
merged 8 commits into from
Jan 22, 2024
Merged

Import automation: Setup script updates #966

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f23d372
updates to the import automation scripts
jehangiramjad Jan 22, 2024
b93eac8
Merge branch 'master' into import-automation
jehangiramjad Jan 22, 2024
efb1a1c
removing client id and secret
jehangiramjad Jan 22, 2024
2dd6e13
updating test file to avoid test failures
jehangiramjad Jan 22, 2024
a458050
lint fixes
jehangiramjad Jan 22, 2024
bae1b5e
relying on setting the params in the environment
jehangiramjad Jan 22, 2024
8813423
updates after reviewer comments
jehangiramjad Jan 22, 2024
3ca06d8
reviewer comments
jehangiramjad Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion import-automation/executor/app/configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class ExecutorConfig:

# ID of the Google Cloud project that hosts the executor. The project
# needs to enable App Engine and Cloud Scheduler.
gcp_project_id: str = 'google.com:datcom-data'
gcp_project_id: str = 'google.com:datcom-import-automation'
jehangiramjad marked this conversation as resolved.
Show resolved Hide resolved
# ID of the Google Cloud project that stores generated CSVs and MCFs. The
# project needs to enable Cloud Storage and gives the service account the
# executor uses sufficient permissions to read and write the bucket below.
Expand Down
5 changes: 2 additions & 3 deletions import-automation/executor/test/integration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@

CONFIGS = {
jehangiramjad marked this conversation as resolved.
Show resolved Hide resolved
# TODO: read the params from the environment.
'github_repo_owner_username':
'datacommonsorg', # os.environ['GITHUB_AUTH_USERNAME'],
'github_repo_owner_username': os.environ['_GITHUB_AUTH_USERNAME'],
'github_repo_name': 'data-demo',
'github_auth_username': '[email protected]',
'github_auth_access_token': '' # os.environ['GITHUB_AUTH_ACCESS_TOKEN']
'github_auth_access_token': os.environ['_GITHUB_AUTH_ACCESS_TOKEN']
}


Expand Down
Loading