Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update covid19 mobility script #629

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update covid19 mobility script #629

wants to merge 6 commits into from

Conversation

pradh
Copy link
Contributor

@pradh pradh commented Feb 18, 2022 •
edited
Loading

  1. Avoid failing with the new CSVs (there was a check for column length)
  2. Migrate from producing unresolved MCFs to TMCF/CSV model
  3. Upgrade the imports etc to follow the typical pattern
  4. Update the tests

Fixes #628

@pradh pradh requested review from beets and shifucun February 18, 2022 02:36
@pradh
Copy link
Contributor Author

pradh commented Feb 25, 2022

Gentle ping. If this gets in, I can try to set up auto-refresh...

beets
beets approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@beets beets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, sorry for the late review

@pradh
Copy link
Contributor Author

pradh commented Feb 25, 2022

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beets beets beets approved these changes

@shifucun shifucun Awaiting requested review from shifucun

Assignees

@Spaceenter Spaceenter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[COVID19 Mobility] Update covid mobility script and resume auto-refresh
3 participants
@pradh @beets @Spaceenter