Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bls_jolts_refresh_import #1153

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Girish3320
Copy link

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this 4.83 MB file necessary for the import? if yes, please use Git LFS to check-in this file.

Copy link
Author

@Girish3320 Girish3320 Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File not needed, it's an output file. Removed output csv and mcf files.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no logging module used in the script

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the retry module to download all the files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please user retry module to implement this. Please refer to https://pypi.org/project/retry/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, along with modes download or process.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement mode flag to control the execution flow of the script like download or process.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants