Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premr uae population import #1016

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

premr
Copy link

@premr premr commented May 2, 2024

UAE population data import

@premr premr requested a review from ajaits May 2, 2024 22:17
@premr premr unassigned ajaits May 2, 2024
Copy link
Contributor

@pradh pradh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohooo!

value: C:Data->value
unit: C:Data->unit
scalingFactor: C:Data->scalingFactor
measurementMethod: C:Data->measurementMethod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unit, scalingFactor and measurementMethod are all empty, so maybe we can skip those properties?

Copy link
Contributor

@ajaits ajaits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Prem!

@premr
Copy link
Author

premr commented May 3, 2024 via email

@pradh
Copy link
Contributor

pradh commented May 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants