Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add postgres schema name in create engine #62

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

datageek00
Copy link
Contributor

@datageek00 datageek00 commented Aug 25, 2023

Fixes/Implements #61

Description

Add postgres schema name while create engine

Type of change

Delete irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Locally Tested

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 96.42% and project coverage change: +0.01% 🎉

Comparison is base (a0e71c5) 82.41% compared to head (9963c7f) 82.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   82.41%   82.43%   +0.01%     
==========================================
  Files          30       30              
  Lines        1052     1053       +1     
==========================================
+ Hits          867      868       +1     
  Misses        185      185              
Files Changed Coverage Δ
datachecks/core/datasource/manager.py 52.94% <ø> (ø)
datachecks/core/inspect.py 56.41% <50.00%> (ø)
datachecks/core/common/models/configuration.py 100.00% <100.00%> (ø)
...achecks/core/configuration/configuration_parser.py 73.01% <100.00%> (ø)
datachecks/core/datasource/sql_datasource.py 95.23% <100.00%> (ø)
datachecks/core/metric/base.py 90.54% <100.00%> (ø)
datachecks/core/metric/numeric_metric.py 90.00% <100.00%> (ø)
datachecks/core/metric/reliability_metric.py 93.10% <100.00%> (ø)
datachecks/core/profiling/datasource_profiling.py 98.07% <100.00%> (ø)
...tachecks/core/profiling/numeric_field_profiling.py 100.00% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subhankarb subhankarb merged commit 5358483 into datachecks:main Aug 26, 2023
7 checks passed
@datageek00 datageek00 deleted the DCS-61 branch August 28, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants