Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): aws redshift datasource #122

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

WeryZebra-Yue
Copy link
Contributor

@WeryZebra-Yue WeryZebra-Yue commented Oct 14, 2023

Fixes/Implements #119

Description

New integration for Redshift.
Using Redshift sqlalchemy to make the connection with Redshift.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Locally Tested

@WeryZebra-Yue WeryZebra-Yue added the ⚡️enhancement New feature or request label Oct 14, 2023
@WeryZebra-Yue WeryZebra-Yue linked an issue Oct 14, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (0aef041) 80.71% compared to head (eb871a0) 79.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   80.71%   79.91%   -0.80%     
==========================================
  Files          38       39       +1     
  Lines        1633     1653      +20     
==========================================
+ Hits         1318     1321       +3     
- Misses        315      332      +17     
Files Coverage Δ
datachecks/core/datasource/manager.py 52.94% <ø> (ø)
datachecks/integrations/databases/redshift.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mkdocs.yml Outdated Show resolved Hide resolved
datachecks/integrations/databases/redshift.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@subhankarb subhankarb merged commit 0e9801f into datachecks:main Oct 15, 2023
7 checks passed
@WeryZebra-Yue WeryZebra-Yue deleted the redshift-datasource branch October 23, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡️enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Redshift Datasource Integration
2 participants