Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): html report slack icon should route to slack #121

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

WeryZebra-Yue
Copy link
Contributor

Fixes/Implements #118

Description

HTML report slack icon is routing to https://www.linkedin.com/company/datachecks/

Expected behavior
HTML report slack icon should route to
https://join.slack.com/t/datachecks/shared_invite/zt-1zqsigy4i-s5aadIh2mjhdpVWU0PstPg

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Locally Tested

@WeryZebra-Yue WeryZebra-Yue added 🐞 bug Something isn't working Dashboard Metric Dashboard labels Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0aef041) 80.71% compared to head (adba976) 80.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files          38       38           
  Lines        1633     1633           
=======================================
  Hits         1318     1318           
  Misses        315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subhankarb subhankarb merged commit 35b48ee into datachecks:main Oct 15, 2023
7 checks passed
@WeryZebra-Yue WeryZebra-Yue deleted the slack-redirect branch October 23, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working Dashboard Metric Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: html report slack icon should route to slack
2 participants