Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(validation): metric validation framework #107

Merged
merged 1 commit into from
Oct 3, 2023
Merged

feat(validation): metric validation framework #107

merged 1 commit into from
Oct 3, 2023

Conversation

WeryZebra-Yue
Copy link
Contributor

@WeryZebra-Yue WeryZebra-Yue commented Sep 26, 2023 •
edited
Loading

Fixes/Implements #37

Description

Absolute - Without History

metrics:
  - name: test-met
    resource: d.t.c
    type: min
    validation:
      threshold: >= 9 & <= 11 | = 9 | < 9 | > 9 | >= 9 | <= 9

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Locally Tested

@WeryZebra-Yue WeryZebra-Yue force-pushed the validation-framework branch 2 times, most recently from f7d633b to 594e69a Compare September 28, 2023 13:30
@WeryZebra-Yue WeryZebra-Yue marked this pull request as ready for review September 28, 2023 13:30
@WeryZebra-Yue WeryZebra-Yue linked an issue Sep 28, 2023 that may be closed by this pull request
feat: Metric Validation Framework #37
Closed
@WeryZebra-Yue WeryZebra-Yue added ⚡️enhancement New feature or request 🔔 validation & alert Metric validation process 📟 CLI labels Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (669f0c6) 84.89% compared to head (1c44a7d) 84.47%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   84.89%   84.47%   -0.42%     
==========================================
  Files          33       34       +1     
  Lines        1410     1475      +65     
==========================================
+ Hits         1197     1246      +49     
- Misses        213      229      +16
Files Coverage Δ
datachecks/core/common/models/configuration.py 100.00% <100.00%> (ø)
datachecks/core/common/models/metric.py 100.00% <100.00%> (ø)
datachecks/core/common/models/validation.py 100.00% <100.00%> (ø)
datachecks/core/metric/combined_metric.py 94.00% <100.00%> (+4.16%) ⬆️
datachecks/core/metric/manager.py 89.58% <ø> (-0.22%) ⬇️
...achecks/core/configuration/configuration_parser.py 81.81% <95.65%> (+3.87%) ⬆️
datachecks/core/metric/base.py 90.56% <93.10%> (+0.56%) ⬆️
datachecks/cli/cli.py 53.22% <25.00%> (-3.92%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WeryZebra-Yue WeryZebra-Yue force-pushed the validation-framework branch 4 times, most recently from 783f14f to a55001e Compare September 28, 2023 14:33
@subhankarb subhankarb merged commit a1f8d55 into datachecks:main Oct 3, 2023
7 checks passed
WeryZebra-Yue added a commit to WeryZebra-Yue/datachecks that referenced this pull request Oct 6, 2023
@WeryZebra-Yue
feat(validation): metric validation framework (datachecks#107)
6971614
@WeryZebra-Yue WeryZebra-Yue deleted the validation-framework branch October 8, 2023 13:23
subhankarb added a commit that referenced this pull request Oct 11, 2023
@WeryZebra-Yue @subhankarb
@dependabot @niyasrad
feat(dashboard): html report framework (#115)
71b404a 
* docs: added tracking for docs (#99)

* bump up version to 0.2.2 (#101)

Co-authored-by: Subhankar <[email protected]>

* Update README.md (#102)

* build(deps): bump cryptography from 41.0.3 to 41.0.4 (#103)

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.4.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.3...41.0.4)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(metrics): implemented sum metric + tests (#109)

* feat(metrics): implemented standard deviation + tests (#108)

* feat(validation): metric validation framework (#107)

* build(deps): bump urllib3 from 1.26.16 to 1.26.17 (#114)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.17.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.16...1.26.17)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(dashboard): html report framework

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Subhankar Biswas <[email protected]>
Co-authored-by: Subhankar <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Niyas Hameed <[email protected]>
WeryZebra-Yue added a commit that referenced this pull request Oct 11, 2023
@WeryZebra-Yue @dependabot
@subhankarb @niyasrad
feat(dashboard): html report framework (#115)
dd32412 
* docs: added tracking for docs (#99)

* bump up version to 0.2.2 (#101)

* Update README.md (#102)

* build(deps): bump cryptography from 41.0.3 to 41.0.4 (#103)

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.4.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.3...41.0.4)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...
feat(dashboard): html report framework (#115)
Signed-off-by: dependabot[bot] <[email protected]>

* feat(metrics): implemented sum metric + tests (#109)

* feat(metrics): implemented standard deviation + tests (#108)

* feat(validation): metric validation framework (#107)

* build(deps): bump urllib3 from 1.26.16 to 1.26.17 (#114)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.17.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.16...1.26.17)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(dashboard): html report framework

---------

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: Subhankar <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Subhankar Biswas <[email protected]>
Co-Authored-By: Subhankar <[email protected]>
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Niyas Hameed <[email protected]>
WeryZebra-Yue added a commit to WeryZebra-Yue/datachecks that referenced this pull request Oct 11, 2023
@WeryZebra-Yue @dependabot
@subhankarb @niyasrad
feat(dashboard): html report framework (datachecks#115)
1169ef9 
* docs: added tracking for docs (datachecks#99)

* bump up version to 0.2.2 (datachecks#101)

* Update README.md (datachecks#102)

* build(deps): bump cryptography from 41.0.3 to 41.0.4 (datachecks#103)

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.4.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.3...41.0.4)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...
feat(dashboard): html report framework (datachecks#115)
Signed-off-by: dependabot[bot] <[email protected]>

* feat(metrics): implemented sum metric + tests (datachecks#109)

* feat(metrics): implemented standard deviation + tests (datachecks#108)

* feat(validation): metric validation framework (datachecks#107)

* build(deps): bump urllib3 from 1.26.16 to 1.26.17 (datachecks#114)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.17.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.16...1.26.17)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* feat(dashboard): html report framework

---------

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Subhankar <[email protected]>
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Subhankar Biswas <[email protected]>
Co-Authored-By: Niyas Hameed <[email protected]>
subhankarb added a commit that referenced this pull request Oct 11, 2023
@datageek00 @WeryZebra-Yue
@dependabot @subhankarb @niyasrad
feat: add initial dashboard framework (#116)
c68d023 
* feat: add initial dashbaord framework

* feat: moved dashboard directory out of core

* feat: cli integration with html report

* feat: add initial dashbaord framework

* feat: moved dashboard directory out of core

* feat: cli integration with html report

* feat: add homepage models

* feat(dashboard): html report framework (#115)

* docs: added tracking for docs (#99)

* bump up version to 0.2.2 (#101)

* Update README.md (#102)

* build(deps): bump cryptography from 41.0.3 to 41.0.4 (#103)

Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.3 to 41.0.4.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@41.0.3...41.0.4)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...
feat(dashboard): html report framework (#115)
Signed-off-by: dependabot[bot] <[email protected]>

* feat(metrics): implemented sum metric + tests (#109)

* feat(metrics): implemented standard deviation + tests (#108)

* feat(validation): metric validation framework (#107)

* build(deps): bump urllib3 from 1.26.16 to 1.26.17 (#114)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.17.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.16...1.26.17)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* feat(dashboard): html report framework

---------

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Subhankar <[email protected]>
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: Subhankar Biswas <[email protected]>
Co-Authored-By: Niyas Hameed <[email protected]>

---------

Co-authored-by: Ayush Master <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Subhankar <[email protected]>
Co-authored-by: Subhankar Biswas <[email protected]>
Co-authored-by: Niyas Hameed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhankarb subhankarb subhankarb approved these changes

@datageek00 datageek00 Awaiting requested review from datageek00

Assignees
No one assigned
Labels
📟 CLI ⚡️enhancement New feature or request 🔔 validation & alert Metric validation process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Metric Validation Framework
2 participants
@WeryZebra-Yue @subhankarb