Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signer module test #19

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Signer module test #19

merged 6 commits into from
Nov 15, 2023

Conversation

siburu
Copy link
Contributor

@siburu siburu commented Nov 14, 2023

No description provided.

@siburu siburu marked this pull request as ready for review November 15, 2023 01:57
@siburu siburu requested review from dongrie and bluele November 15, 2023 01:58
@siburu
Copy link
Contributor Author

siburu commented Nov 15, 2023

@dongrie (cc @bluele) This PR is for supporting Signer abstraction, which was introduced in [email protected]. Please review the changes.

Copy link

@dongrie dongrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@siburu siburu merged commit 34dfae3 into datachainlab:v0.4 Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants