Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the dns module to the version of cosmos-sdk v0.40.0-rc3 #7

Merged
merged 9 commits into from
Nov 18, 2020

Conversation

toshihiko-okubo
Copy link
Member

No description provided.

@toshihiko-okubo toshihiko-okubo force-pushed the update_to_stargate branch 2 times, most recently from 2c8e2d2 to 50c4a2f Compare November 9, 2020 09:00
@toshihiko-okubo toshihiko-okubo changed the title WIP update the dns module to the version of cosmos-sdk v0.40.0-rc2WIP Nov 9, 2020
@toshihiko-okubo toshihiko-okubo changed the title update the dns module to the version of cosmos-sdk v0.40.0-rc2WIP update the dns module to the version of cosmos-sdk v0.40.0-rc2 Nov 9, 2020
@toshihiko-okubo toshihiko-okubo force-pushed the update_to_stargate branch 7 times, most recently from c55e129 to 06a66f5 Compare November 10, 2020 02:04
@toshihiko-okubo toshihiko-okubo force-pushed the update_to_stargate branch 3 times, most recently from 3d061b2 to a355bce Compare November 10, 2020 06:37
@toshihiko-okubo toshihiko-okubo changed the base branch from master to update-sdk November 10, 2020 06:42
@toshihiko-okubo toshihiko-okubo force-pushed the update_to_stargate branch 3 times, most recently from 45fcee7 to c5d4bc9 Compare November 10, 2020 07:39
func (p RegisterDomainPacketData) GetTimeoutHeight() uint64 {
return math.MaxUint64
func (p RegisterDomainPacketData) GetTimeoutHeight() ibcclienttypes.Height {
return ibcclienttypes.NewHeight(0, math.MaxInt64)
Copy link
Member Author

@toshihiko-okubo toshihiko-okubo Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If MaxUint64 is specified, Overflow may occur with the following Code

https://github.com/cosmos/cosmos-sdk/blob/master/x/ibc/core/02-client/types/height.go#L61

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed it at this commit.
After a new version that includes this commit is released, we should revert the changes.

Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toshihiko-okubo
The implementation looks good!
I have two suggestions:

  • Can you move x/ibc-dns/testing directory to under x/ibc ? This is because we want to separate ibc testing module from dns package.
  • And sorry, can you use the SDK version v0.40.3-rc-3?

@toshihiko-okubo toshihiko-okubo changed the title update the dns module to the version of cosmos-sdk v0.40.0-rc2 update the dns module to the version of cosmos-sdk v0.40.0-rc3 Nov 18, 2020
@bluele bluele merged commit 669b79b into update-sdk Nov 18, 2020
@bluele bluele deleted the update_to_stargate branch November 18, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants