Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech Debt: Fixed issue with Incorrect unit test practice #3244

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Tech Debt: Fixed issue with Incorrect unit test practice #3244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions tests/unit/aws/test_access.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import json
import logging
from unittest.mock import MagicMock, call, create_autospec
from unittest.mock import call, create_autospec

import pytest
from databricks.labs.blueprint.installation import MockInstallation
from databricks.labs.blueprint.tui import MockPrompts
from databricks.labs.lsql.backends import MockBackend
from databricks.sdk import WorkspaceClient
from databricks.sdk.errors import ResourceDoesNotExist, PermissionDenied
from databricks.sdk.errors import PermissionDenied
from databricks.sdk.service import iam
from databricks.sdk.service.catalog import (
AwsIamRoleResponse,
Expand All @@ -23,7 +23,7 @@
GetWorkspaceWarehouseConfigResponseSecurityPolicy,
)

from databricks.labs.ucx.assessment.aws import AWSPolicyAction, AWSResources, AWSRole, AWSRoleAction
from databricks.labs.ucx.assessment.aws import AWSPolicyAction, AWSResources, AWSRole
from databricks.labs.ucx.aws.access import AWSResourcePermissions
from databricks.labs.ucx.aws.credentials import IamRoleCreation
from databricks.labs.ucx.aws.locations import AWSExternalLocationsMigration
Expand Down Expand Up @@ -517,14 +517,7 @@ def test_get_uc_compatible_roles(mock_ws, mock_installation, locations):
aws,
locations,
)
# TODO: this is bad practice, we should not be mocking load() methon on a MockInstallation class
mock_installation.load = MagicMock(
side_effect=[
ResourceDoesNotExist(),
[AWSRoleAction("arn:aws:iam::12345:role/uc-role1", "s3", "WRITE_FILES", "s3://BUCKETX/*")],
]
)
aws_resource_permissions.load_uc_compatible_roles()
aws_resource_permissions.save_uc_compatible_roles()
mock_installation.assert_file_written(
'uc_roles_access.csv',
[
Expand Down