fix docstring so that edgeratio=0 is not boundingbox #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the branch is misnamed sorry, this is about the concavehull, not convexhull)
If I understand correctly,
ST_Concavehull
withedgeRatio=0
does not produce the bounding box, but something that could be described like "vacuum-wrapping" the object. The more precise but more boring description of "maximum concaveness", from the formal definition of JTS.(In the current tests, the edgeRatio=0.01 does not produce a rectangular, coordinate-aligned bounding box either.)
Related, the ratio itself is not between the convex and concave hull but some fancier ratio related to the Delaunay triangulation.
I suggest for both to take over, the wording from JTS.