Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docstring so that edgeratio=0 is not boundingbox #504

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

danielsparing
Copy link
Contributor

(the branch is misnamed sorry, this is about the concavehull, not convexhull)

If I understand correctly, ST_Concavehull with edgeRatio=0 does not produce the bounding box, but something that could be described like "vacuum-wrapping" the object. The more precise but more boring description of "maximum concaveness", from the formal definition of JTS.
(In the current tests, the edgeRatio=0.01 does not produce a rectangular, coordinate-aligned bounding box either.)

Related, the ratio itself is not between the convex and concave hull but some fancier ratio related to the Delaunay triangulation.

I suggest for both to take over, the wording from JTS.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8fa5d6a) 93.86% compared to head (4b4ec85) 93.86%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         241      241           
  Lines        6241     6241           
  Branches      108      108           
=======================================
  Hits         5858     5858           
  Misses        383      383           
Files Coverage Δ
...s/mosaic/expressions/geometry/ST_ConcaveHull.scala 100.00% <ø> (ø)

@milos-colic milos-colic merged commit ad63f6e into main Jan 15, 2024
9 checks passed
@danielsparing danielsparing deleted the convexhull-docstring branch January 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants