Fix to netcdf read process #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 93.81% 93.99% +0.18%
==========================================
Files 241 245 +4
Lines 6244 6548 +304
Branches 108 113 +5
==========================================
+ Hits 5858 6155 +297
- Misses 386 393 +7
|
… reference of rasters
…a/fix/netcdf # Conflicts: # src/main/scala/com/databricks/labs/mosaic/core/types/model/MosaicRasterTile.scala
|
|
# Conflicts: # src/main/scala/com/databricks/labs/mosaic/core/geometry/MosaicGeometryESRI.scala # src/test/scala/com/databricks/labs/mosaic/core/index/H3IndexSystemTest.scala
# Conflicts: # python/mosaic/api/aggregators.py # python/mosaic/api/fuse.py # python/mosaic/api/gdal.py # python/mosaic/api/raster.py # python/mosaic/core/library_handler.py # python/test/utils/setup_gdal.py # python/test/utils/spark_test_case.py
milos-colic
approved these changes
Feb 13, 2024
| val result = GDALTranslate.executeTranslate( | ||
| rasterPath, | ||
| raster, | ||
| command = s"gdal_translate -of $shortDriver -b ${i + 1} -co COMPRESS=DEFLATE" |
There was a problem hiding this comment.
@sllynn this should not explicitly state DEFLATE, this can be inferred from the raster. and we should propagate.
I will fix it in my PR so should not block the PR
| @@ -39,7 +40,22 @@ trait RST_TessellateBehaviors extends QueryTest { | |||
|
|
|||
| val result = gridTiles.collect() | |||
|
|
|||
| result.length should be(380) | |||
| result.length should be(980) | |||
There was a problem hiding this comment.
@sllynn this doesnt feel right. why did this go from 380 to 980?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working around the repeated calls to
gdalinfoduring reads to check for empty tiles when rasters have many bands.