Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R package fixes & improvements #455

Merged
merged 6 commits into from
Nov 29, 2023
Merged

R package fixes & improvements #455

merged 6 commits into from
Nov 29, 2023

Conversation

sllynn
Copy link
Contributor

@sllynn sllynn commented Nov 14, 2023

Updates to the boilerplate parts of sparklyr bindings and addition of some testthat tests to both sparklyr and sparkr bindings.

@sllynn sllynn changed the title testthat tests for R package R package fixes & improvements Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #455 (5674422) into main (f5525c5) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files         243      243           
  Lines        6675     6675           
  Branches      233      233           
=======================================
  Hits         6146     6146           
  Misses        529      529           

@sllynn sllynn marked this pull request as ready for review November 15, 2023 10:11
R/build_r_package.R Outdated Show resolved Hide resolved
Copy link
Contributor

@milos-colic milos-colic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 comments, looks good to me in general

R/generate_docs.R Outdated Show resolved Hide resolved
Copy link
Contributor

@milos-colic milos-colic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@milos-colic milos-colic merged commit c4cce0f into main Nov 29, 2023
9 checks passed
@a0x8o a0x8o mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants