Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Delta 2.1.0 and Spark 3.3 #24

Merged
merged 18 commits into from
Oct 5, 2022
Merged

Upgrade to Delta 2.1.0 and Spark 3.3 #24

merged 18 commits into from
Oct 5, 2022

Conversation

himanishk
Copy link
Contributor

  • Upgrade to Delta 2.1.0 and Spark 3.3
  • Switch to using AvailableNow as default Trigger interval
  • Documentation updates

 - Change default trigger interval to AvailableNow instead of TriggerOnce
 - Updated documentation and test cases
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #24 (4bd2135) into master (c5d6aba) will increase coverage by 0.38%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   89.38%   89.77%   +0.38%     
==========================================
  Files           8        8              
  Lines         490      489       -1     
  Branches       27       30       +3     
==========================================
+ Hits          438      439       +1     
+ Misses         52       50       -2     
Impacted Files Coverage Δ
...atabricks/labs/deltaoms/common/OMSOperations.scala 78.07% <90.90%> (ø)
...databricks/labs/deltaoms/common/OMSSparkConf.scala 100.00% <100.00%> (ø)
...bricks/labs/deltaoms/utils/UtilityOperations.scala 100.00% <100.00%> (+1.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@aemrob aemrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@aemrob aemrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himanishk
Copy link
Contributor Author

@alexott @nfx - @aemrob has looked into these changes and approved them. Unfortunately, the PR still shows 1 approving review is required . Maybe we do not have the correct permissions.

Could you please approve the changes for me to MERGE these changes and make a release. Thanks

Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the code and instructions to be compatible with Databricks License

build.sbt Outdated
ShadeRule.rename("org.apache.spark.sql.delta.**" ->
"com.databricks.sql.transaction.tahoe.@1").inAll
),
if (buildTarget == "db") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it only-Databricks target 😉 it must not run outside of Databricks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfx , ok. Made the changes

docs/content/faq/general.md Show resolved Hide resolved
@himanishk himanishk requested a review from nfx September 30, 2022 15:00
@himanishk himanishk merged commit ac6161c into master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants