-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Delta 2.1.0 and Spark 3.3 #24
Conversation
himanishk
commented
Aug 31, 2022
- Upgrade to Delta 2.1.0 and Spark 3.3
- Switch to using AvailableNow as default Trigger interval
- Documentation updates
- Change default trigger interval to AvailableNow instead of TriggerOnce - Updated documentation and test cases
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 89.38% 89.77% +0.38%
==========================================
Files 8 8
Lines 490 489 -1
Branches 27 30 +3
==========================================
+ Hits 438 439 +1
+ Misses 52 50 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Fixed test cases due to changes - Added rate limiting and incremental processing for AvailableNow trigger
- Ignore exception for DbUtils calls (for non Databricks environments) - Updated test cases
…ible jar - Updated test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust the code and instructions to be compatible with Databricks License
build.sbt
Outdated
ShadeRule.rename("org.apache.spark.sql.delta.**" -> | ||
"com.databricks.sql.transaction.tahoe.@1").inAll | ||
), | ||
if (buildTarget == "db") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it only-Databricks target 😉 it must not run outside of Databricks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nfx , ok. Made the changes