Updated build.sbt and release workflow #15
Merged
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to PureConfig configuration library
…r to PureConfig configuration library
…r to PureConfig configuration library
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 8 8
Lines 440 440
Branches 31 31
=======================================
Hits 383 383
Misses 57 57 Continue to review full report at Codecov.
|
nfx
approved these changes
Sep 23, 2021
| @@ -10,6 +10,6 @@ Make sure you have the following available before proceeding : | |||
| - Access to Databricks environment with access to Delta tables/databases | |||
| - Ability to create Databricks job and run them on new cluster | |||
| - Proper access permissions to create database, tables and write data to the desired OMS location | |||
| - Procured the Delta OMS solution package from your Databricks team (includes DeltaOMS jar , | |||
| sample notebooks and documentations) | |||
| - Access to create [libraries](https://github.com/pureconfig/pureconfig) on your Databricks environment. Required to attach the relevant DeltaOMS (delta-oms) and PureConfig maven `com.github.pureconfig:pureconfig_2.12:0.14.0` libraries | |||
There was a problem hiding this comment.
@himanishk can you try making next release without pureconfig requirement? databricks runtime already has some config management libraries. The less third-party jars required - the faster adoption will be
There was a problem hiding this comment.
Thanks @nfx . Will explore for next release to keep things simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update release workflow