Fix median to support multi-index columns. #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 34 34
Lines 6519 6519
=======================================
Hits 6183 6183
Misses 336 336
Continue to review full report at Codecov.
|
itholic
reviewed
Nov 2, 2019
Softagram Impact Report for pull/995 (head commit: e1d0b07)⭐ Change Overview
💡 Insights
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
HyukjinKwon
reviewed
Nov 5, 2019
| sdf = sdf.select([median(col).alias(col) for col in kdf._internal.data_columns]) | ||
|
|
||
| # Attach a dummy column for index to avoid default index. | ||
| sdf = sdf.withColumn('__DUMMY__', F.monotonically_increasing_id()) |
There was a problem hiding this comment.
Hmmm .. maybe we should just document __...__ columns are reserved in Koalas .. of course in a separate PR..
HyukjinKwon
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
_Frame.median()to:_scolforSeries.DataFrame.