Fix Dataframe.melt function & Add doctest case for melt function #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice finding |
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 94.83% 94.96% +0.13%
==========================================
Files 34 34
Lines 6640 6713 +73
==========================================
+ Hits 6297 6375 +78
+ Misses 343 338 -5
Continue to review full report at Codecov.
|
…e not present in the Dataframe
|
@ueshin |
ueshin
reviewed
Nov 4, 2019
ueshin
reviewed
Nov 5, 2019
ueshin
reviewed
Nov 8, 2019
databricks/koalas/frame.py
Outdated
Comment on lines
6819
to
6820
| raise KeyError("None of [{}] are in the [columns]" | ||
| .format(pd.MultiIndex.from_tuples(non_existence_col))) |
There was a problem hiding this comment.
The error message is strange?
KeyError: "None of [MultiIndex(levels=[['X'], ['Y']],\n codes=[[0], [0]])] are in the [columns]"
How about:
- raise KeyError("None of [{}] are in the [columns]"
- .format(pd.MultiIndex.from_tuples(non_existence_col)))
+ raise KeyError("None of {} are in the {}"
+ .format(non_existence_col, column_index))then
KeyError: "None of [('X', 'Y')] are in the [('X', 'A'), ('X', 'B'), ('Y', 'C')]"
There was a problem hiding this comment.
I agree with you.
I'll change error message the case of id_vars, value_vars.
databricks/koalas/frame.py
Outdated
Comment on lines
6847
to
6848
| raise KeyError("None of [{}] are in the [columns]" | ||
| .format(pd.MultiIndex.from_tuples(non_existence_col))) |
Softagram Impact Report for pull/987 (head commit: 551b3ea)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no test that tested with
str, tuple typeofvalue_varsparameter at Dataframe.melt function.I update doctest case.
And, I thought, There is a bug like the image below.
I changed some codes.