-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement expanding().count() in Series and Frame #978
Conversation
0adacc4
to
157aa84
Compare
157aa84
to
46d3a78
Compare
Softagram Impact Report for pull/978 (head commit: 46d3a78)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
raise ValueError("min_periods must be >= 0") | ||
self._min_periods = min_periods | ||
self.kdf_or_kser = kdf_or_kser | ||
if not isinstance(kdf_or_kser, (DataFrame, Series, DataFrameGroupBy, SeriesGroupBy)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this one nicer when I add count
into DataFrameGroupBy
and SeriesGroupBy
in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending tests.
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 94.82% 94.84% +0.02%
==========================================
Files 34 34
Lines 6489 6519 +30
==========================================
+ Hits 6153 6183 +30
Misses 336 336
Continue to review full report at Codecov.
|
Thanks @ueshin ! |
This PR implements
expanding().count()
:Relates to #977