Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing options as keyword arguments #968

Merged
merged 3 commits into from
Oct 29, 2019

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Oct 28, 2019

Resolves #967.

@rxin
Copy link
Contributor

rxin commented Oct 28, 2019

This is embarrassing :( We should add a test case.

@ueshin
Copy link
Collaborator Author

ueshin commented Oct 28, 2019

Yup, let me add some.

@codecov-io
Copy link

codecov-io commented Oct 28, 2019

Codecov Report

Merging #968 into master will increase coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
+ Coverage   94.55%   94.57%   +0.01%     
==========================================
  Files          34       34              
  Lines        6483     6483              
==========================================
+ Hits         6130     6131       +1     
+ Misses        353      352       -1
Impacted Files Coverage Δ
databricks/koalas/frame.py 96.03% <ø> (ø) ⬆️
databricks/koalas/namespace.py 87.14% <60%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979f4b8...7be55ad. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/968 (head commit: 7be55ad)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

💡 Insights

  • Co-change Alert: You modified frame.py. Often test_dataframe.py (koalas/tests) is modified at the same time.

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon HyukjinKwon changed the title Fix passing options. Fix passing options as keyword arguments Oct 29, 2019
@HyukjinKwon HyukjinKwon merged commit 8b0f760 into databricks:master Oct 29, 2019
@ueshin ueshin deleted the options branch October 29, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The options argument is not passed to Spark reader properly.
5 participants