Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the base for expanding and rolling in Series, Frame, SeriesGroupby and FrameGroupby #840

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Add the base for expanding and rolling in Series, Frame, SeriesGroupby and FrameGroupby #840

merged 4 commits into from
Oct 1, 2019

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Sep 28, 2019 •
edited
Loading

This PR adds:

  • Missing mechanism for expanding and rolling in Seres, Frame, SeriesGroupby and FrameGroupby
  • Add the documentation base for expanding and rolling

by mimicking pandas class structure.

Partially addresses #807

ueshin
ueshin reviewed Sep 30, 2019
View reviewed changes
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these classes to usage logging?
I guess just adding them to usage_logging/__init__.py should work.
Otherwise, LGTM.

@HyukjinKwon
Copy link
Member Author

Oh sure. Will do.

@softagram-bot
Copy link

Softagram Impact Report for pull/840 (head commit: 4b110a1)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

⭐ Details of Dependency Changes

details of dependency changes - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon
Copy link
Member Author

Thanks @ueshin ! merged.

@HyukjinKwon HyukjinKwon merged commit dfbcd95 into databricks:master Oct 1, 2019
@ueshin ueshin mentioned this pull request Oct 1, 2019
Merged
@ueshin
Copy link
Collaborator

ueshin commented Oct 1, 2019

Sorry that I didn't make clear. Actually we need to the classes too. #855

ueshin added a commit that referenced this pull request Oct 1, 2019
@ueshin
Add Expanding and Rolling to usage logging. (#855)
e52e70f 
This is a followup of #840.
@HyukjinKwon
Copy link
Member Author

Thanks!

@ppakawatk
Copy link

Hi,

Does the mechanism for aggregating (e.g. mean) after rolling being added sir?
I'm using Koalas 0.20, and getting this "
PandasNotImplementedError: The method pandas.core.window.Rolling.mean() is not implemented yet.".

@HyukjinKwon
Copy link
Member Author

It's not implemented yet. These will be implemented in the near future.

@HyukjinKwon HyukjinKwon deleted the rolling-expanding branch November 6, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueshin ueshin ueshin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HyukjinKwon @softagram-bot @ueshin @ppakawatk