Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace support in options #785

Merged
merged 3 commits into from
Sep 19, 2019

Conversation

HyukjinKwon
Copy link
Member

This PR adds the support for options to be set like attributes.

>>> import databricks.koalas as ks
>>> ks.options.display.max_rows
1000
>>> ks.options.display.max_rows = 10
>>> ks.options.display.max_rows
10

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #785 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   94.28%   94.32%   +0.03%     
==========================================
  Files          32       32              
  Lines        5776     5812      +36     
==========================================
+ Hits         5446     5482      +36     
  Misses        330      330
Impacted Files Coverage Δ
databricks/koalas/__init__.py 85% <100%> (ø) ⬆️
databricks/koalas/config.py 87.35% <100%> (+8.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216e524...d740c34. Read the comment docs.

@HyukjinKwon HyukjinKwon force-pushed the namespace-options branch 2 times, most recently from 7d8f5b5 to dc022f2 Compare September 17, 2019 06:44
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

databricks/koalas/config.py Outdated Show resolved Hide resolved
databricks/koalas/config.py Outdated Show resolved Hide resolved
@HyukjinKwon
Copy link
Member Author

Thanks for detailed review @ueshin always!

@softagram-bot
Copy link

Softagram Impact Report for pull/785 (head commit: d740c34)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon
Copy link
Member Author

Today is the release date. I am merging it in

@HyukjinKwon HyukjinKwon merged commit a6710d0 into databricks:master Sep 19, 2019
@HyukjinKwon HyukjinKwon deleted the namespace-options branch November 6, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants