Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "sep" parameter for read_csv #777

Merged
merged 2 commits into from
Sep 14, 2019
Merged

Add "sep" parameter for read_csv #777

merged 2 commits into from
Sep 14, 2019

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Sep 14, 2019

Resolves #770

@softagram-bot
Copy link

Softagram Impact Report for pull/777 (head commit: 9c11bc2)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@codecov-io
Copy link

Codecov Report

Merging #777 into master will decrease coverage by 1.94%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #777      +/-   ##
=========================================
- Coverage   93.84%   91.9%   -1.95%     
=========================================
  Files          32      32              
  Lines        5755    5756       +1     
=========================================
- Hits         5401    5290     -111     
- Misses        354     466     +112
Impacted Files Coverage Δ
databricks/koalas/namespace.py 81.29% <100%> (+0.06%) ⬆️
databricks/koalas/usage_logging/__init__.py 23.14% <0%> (-74.08%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 75% <0%> (-10%) ⬇️
databricks/conftest.py 90.69% <0%> (-6.98%) ⬇️
databricks/koalas/frame.py 95.75% <0%> (-0.71%) ⬇️
databricks/koalas/generic.py 94.7% <0%> (-0.53%) ⬇️
databricks/koalas/internal.py 95.83% <0%> (-0.47%) ⬇️
databricks/koalas/plot.py 93.73% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b1bf5...9c11bc2. Read the comment docs.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ueshin
Copy link
Collaborator

ueshin commented Sep 14, 2019

Thanks! merging.

@ueshin ueshin merged commit 57c9abb into databricks:master Sep 14, 2019
@harupy
Copy link
Contributor Author

harupy commented Sep 14, 2019

@ueshin Thanks!

@harupy harupy deleted the add_sep branch October 5, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "sep" parameter for read_csv
4 participants