Add axis parameter to dataframe.diff #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #774 +/- ##
==========================================
- Coverage 93.9% 93.84% -0.06%
==========================================
Files 32 32
Lines 5691 5755 +64
==========================================
+ Hits 5344 5401 +57
- Misses 347 354 +7
Continue to review full report at Codecov.
|
HyukjinKwon
reviewed
Sep 12, 2019
HyukjinKwon
approved these changes
Sep 12, 2019
ueshin
reviewed
Sep 12, 2019
ueshin
reviewed
Sep 12, 2019
ueshin
reviewed
Sep 13, 2019
databricks/koalas/frame.py
Outdated
| @@ -2267,7 +2271,8 @@ def diff(self, periods=1): | |||
| internal = self._internal.copy(sdf=sdf, data_columns=[c.name for c in applied]) | |||
| return DataFrame(internal) | |||
|
|
|||
| def nunique(self, axis: int = 0, dropna: bool = True, approx: bool = False, | |||
| # TODO: axis should support 1 or 'columns' either | |||
There was a problem hiding this comment.
We need to add "at this moment" here as well?
There was a problem hiding this comment.
@ueshin Thanks, I just added it !
Softagram Impact Report for pull/774 (head commit: de9ecdc)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pandas dataframe support axis parameter in dataframe.diff.
I think we need to support it either. (And it was already commented as TODO)
In addition, now the nunique function only support the axis parameter as 0 (without 'index'), also fix it.
And currently we only support axis 0, or axis 1 for some functions, so i plan to implement it soon.