Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support None to unlimit 'display.max_rows' #742

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

HyukjinKwon
Copy link
Member

This PR adds the support to unlimit the number of rows at 'display.max_rows'.

>>> import databricks.koalas as ks
>>> ks.set_option("display.max_rows", None)
>>> ks.range(1001)
        id
0        0
1        1
...
1018  1018
1019  1019

[1020 rows x 1 columns]

@@ -130,7 +132,6 @@ def validate(self, v: Any) -> None:
lambda v: v is None or v >= 0,
"'compute.max_rows' should be greater than or equal to 0.")),

# TODO: None should support unlimited.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortcut_limit cannot support None as at least it needs empty dataframe to infer its type when its needed.

@softagram-bot
Copy link

Softagram Impact Report for pull/742 (head commit: f7d979c)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@codecov-io
Copy link

Codecov Report

Merging #742 into master will decrease coverage by 2.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
- Coverage   94.03%   91.67%   -2.36%     
==========================================
  Files          32       32              
  Lines        5650     5659       +9     
==========================================
- Hits         5313     5188     -125     
- Misses        337      471     +134
Impacted Files Coverage Δ
databricks/koalas/config.py 100% <ø> (ø) ⬆️
databricks/koalas/series.py 95.02% <100%> (-0.17%) ⬇️
databricks/koalas/indexes.py 97.29% <100%> (+0.07%) ⬆️
databricks/koalas/frame.py 94.53% <100%> (-1.7%) ⬇️
databricks/koalas/usage_logging/__init__.py 23.14% <0%> (-74.08%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 77.5% <0%> (-7.5%) ⬇️
databricks/conftest.py 90.69% <0%> (-6.98%) ⬇️
databricks/koalas/namespace.py 79.66% <0%> (-1.34%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625cea6...f7d979c. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit e3f4cab into databricks:master Sep 4, 2019
@HyukjinKwon HyukjinKwon deleted the display.max_rows-None branch November 6, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants