Add some missing exception tests for base.py #734
Merged
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Sep 2, 2019
databricks/koalas/base.py
Outdated
| @@ -385,6 +385,9 @@ def astype(self, dtype): | |||
|
|
|||
| >>> ser.rename("a").to_frame().set_index("a").index.astype('int64') | |||
| Int64Index([1, 2], dtype='int64', name='a') | |||
|
|
|||
| >>> ser.astype('int63') | |||
| ValueError: Type int63 not understood | |||
There was a problem hiding this comment.
For such test, we should add it under koalas/tests/... rather than doctest because it becomes the part of documentation.
There was a problem hiding this comment.
Thanks for comment. i'll fix and commit again
Softagram Impact Report for pull/734 (head commit: 01f9145)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
=========================================
+ Coverage 94.24% 94.4% +0.16%
=========================================
Files 32 32
Lines 5579 5579
=========================================
+ Hits 5258 5267 +9
+ Misses 321 312 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some missing exception tests in base.py
i added them some for doctest,
one for pytest
(but this test is currently being skipped for some reason
so maybe does not directly affect coverage.)
could someone check this when if available.
Thanks.