Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting.max_rows #728

Merged
merged 16 commits into from
Sep 2, 2019

Conversation

charlesdong1991
Copy link
Contributor

No description provided.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

@codecov-io
Copy link

codecov-io commented Sep 2, 2019

Codecov Report

Merging #728 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #728      +/-   ##
=========================================
+ Coverage   94.24%   94.4%   +0.16%     
=========================================
  Files          32      32              
  Lines        5579    5580       +1     
=========================================
+ Hits         5258    5268      +10     
+ Misses        321     312       -9
Impacted Files Coverage Δ
databricks/koalas/config.py 100% <ø> (ø) ⬆️
databricks/koalas/plot.py 94.91% <100%> (+1.12%) ⬆️
databricks/koalas/series.py 95.18% <0%> (+0.17%) ⬆️
databricks/koalas/frame.py 95.12% <0%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a7fa4...8e70b39. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/728 (head commit: 8e70b39)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon
Copy link
Member

Thanks for doing this, @charlesdong1991 ! merged.

@HyukjinKwon HyukjinKwon merged commit b876400 into databricks:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants