Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for groupby #709

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Aug 28, 2019

Added missing tests or tests that weren't running properly for groupby.

I would be grateful if someone could check when possible.

Thanks.

@softagram-bot
Copy link

Softagram Impact Report for pull/709 (head commit: d1ac086)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to [email protected]

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #709 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   93.87%   94.01%   +0.14%     
==========================================
  Files          32       32              
  Lines        5548     5548              
==========================================
+ Hits         5208     5216       +8     
+ Misses        340      332       -8
Impacted Files Coverage Δ
databricks/koalas/groupby.py 90.11% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7028e...d1ac086. Read the comment docs.

@HyukjinKwon
Copy link
Member

@itholic, you can show the missing coverage next time with the screenshot like you did before.

@HyukjinKwon HyukjinKwon merged commit 8b62fcc into databricks:master Aug 28, 2019
@itholic
Copy link
Contributor Author

itholic commented Aug 28, 2019

@HyukjinKwon, Oh I was worried that maybe it would be too much information. But I will upload the screen together in the future as you have advised me. Thank you for your advice!

@itholic itholic deleted the add_test_for_groupby branch August 28, 2019 12:56
@itholic itholic restored the add_test_for_groupby branch August 28, 2019 13:47
@itholic itholic deleted the add_test_for_groupby branch August 29, 2019 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants