-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for reverse operator at Series #694
Add test for reverse operator at Series #694
Conversation
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 93.71% 93.84% +0.12%
==========================================
Files 32 32
Lines 5523 5523
==========================================
+ Hits 5176 5183 +7
+ Misses 347 340 -7
Continue to review full report at Codecov.
|
databricks/koalas/series.py
Outdated
@@ -217,6 +343,27 @@ | |||
Name: a, dtype: float64 | |||
""" | |||
|
|||
_rfloordiv_example_SERIES = """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itholic, can you maybe just add the new example into _floordiv_example_SERIES
? This doc looks unnecessarily getting long. For instance,
_floordiv_example_SERIES = """
Examples
--------
>>> df = ks.DataFrame({'a': [2, 2, 4, np.nan],
... 'b': [2, np.nan, 2, np.nan]},
... index=['a', 'b', 'c', 'd'], columns=['a', 'b'])
>>> df
a b
a 2.0 2.0
b 2.0 NaN
c 4.0 2.0
d NaN NaN
>>> df.a.floordiv(df.b)
a 1.0
b NaN
c 2.0
d NaN
Name: a, dtype: float64
>>> df.a.rfloordiv(df.b)
a 0.0
b NaN
c -2.0
d NaN
Name: a, dtype: float64
"""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon , The test structure was changed based on your comments. Can you confirm that I made the change when you available? Thanks for your comment.
Softagram Impact Report for pull/694 (head commit: 2a3acaf)⭐ Change Overview
📄 Full report
Give feedback on this report to [email protected] |
Added missing parts for the reverse operator at Series.
such as radd, rsub, and rdiv and so on.
And to make the result different from the reverse operator,
I made some changes to the data in the existing example.