Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests for indexes #692

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Aug 26, 2019

I found that there was not enough exception testing for the names property.

image

So I added tests for those exceptions,

And also added tests for some other code that isn't being tested yet.

It's very appreciate it if someone check it out when available. :)

Thanks.

@softagram-bot
Copy link

Softagram Impact Report for pull/692 (head commit: c63c629)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to [email protected]

@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #692 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   93.54%   93.65%   +0.11%     
==========================================
  Files          32       32              
  Lines        5455     5455              
==========================================
+ Hits         5103     5109       +6     
+ Misses        352      346       -6
Impacted Files Coverage Δ
databricks/koalas/indexes.py 97.19% <0%> (+5.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b8bfb...c63c629. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 8e0a2a8 into databricks:master Aug 26, 2019
@itholic itholic deleted the test_indexes branch August 28, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants