Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implement frame plot #686

Merged
merged 7 commits into from
Aug 26, 2019

Conversation

charlesdong1991
Copy link
Contributor

@charlesdong1991 charlesdong1991 commented Aug 24, 2019

This PR is mainly creating frame plot which is kind of base method, now, only line plot is added.

koalas plot:

Screen Shot 2019-08-26 at 9 22 39 AM

pandas plot:

Screen Shot 2019-08-26 at 1 17 28 PM

@codecov-io
Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #686 into master will increase coverage by 0.15%.
The diff coverage is 97.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   93.52%   93.68%   +0.15%     
==========================================
  Files          32       32              
  Lines        5455     5492      +37     
==========================================
+ Hits         5102     5145      +43     
+ Misses        353      347       -6
Impacted Files Coverage Δ
databricks/koalas/frame.py 94.74% <100%> (+0.01%) ⬆️
databricks/koalas/plot.py 94.86% <97.29%> (+0.58%) ⬆️
databricks/koalas/internal.py 96.15% <0%> (ø) ⬆️
databricks/koalas/indexes.py 97.19% <0%> (+5.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba6c83...14a55b5. Read the comment docs.

@charlesdong1991 charlesdong1991 changed the title Implement frame plot ENH: Implement frame plot Aug 24, 2019
table=table, yerr=yerr, xerr=xerr, secondary_y=secondary_y,
sort_columns=sort_columns, **kwds)

def line(self, x=None, y=None, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mimic pandas documenation (https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.plot.line.html#pandas.DataFrame.plot.line)? It's okay to don't include the images for now.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlesdong1991.

@charlesdong1991
Copy link
Contributor Author

charlesdong1991 commented Aug 26, 2019

Screen Shot 2019-08-26 at 9 22 39 AM

Hi, @HyukjinKwon thanks for taking a look at the PR, and I changed the code to reflect your points in the review. And here I attach the output with the test example code.

@softagram-bot
Copy link

Softagram Impact Report for pull/686 (head commit: 14a55b5)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback on this report to [email protected]

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except, do you mind if I ask to post pandas example (input/output) too in PR description as well? Just want to make sure that it shows the same chart.

@charlesdong1991
Copy link
Contributor Author

thanks for your feedback, fair enough! I added it in the description. Once it's merged, then I will add other sub modules for frame plot. @HyukjinKwon

@HyukjinKwon
Copy link
Member

Merged to master.

Thanks you for addressing my comments.

@HyukjinKwon HyukjinKwon merged commit 446d393 into databricks:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants