-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Series.fillna #317
Series.fillna #317
Conversation
ks = koalas.from_pandas(ps) | ||
|
||
self.assert_eq(ks.fillna(0), ps.fillna(0)) | ||
self.assert_eq(ks.fillna({'x': 0}), ps.fillna(0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that Pandas.Series.fillna
supports neither Series
nor dict
as value.
Koalas.Series.fillna
does!
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
==========================================
+ Coverage 93.81% 94.06% +0.24%
==========================================
Files 34 35 +1
Lines 3315 3454 +139
==========================================
+ Hits 3110 3249 +139
Misses 205 205
Continue to review full report at Codecov.
|
databricks/koalas/series.py
Outdated
|
||
Parameters | ||
---------- | ||
value : scalar, dict, Series |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should just follow pandas here and drop dict/Series. This is a Series, so there's only one column really.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rxin
Pandas doc says that it supports dict
& Series
.
But I think the doc is a copy paste of DataFrame.fillna
.
Anyway, we can remove them from the docstring.
@rxin I left only |
Thanks. I've merged this. This will be available as part of release 0.4. |
Series.fillna()
Series.fillna #308