Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the upperbound for numpy. #2166

Merged
merged 7 commits into from
Jun 9, 2021
Merged

Remove the upperbound for numpy. #2166

merged 7 commits into from
Jun 9, 2021

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Jun 8, 2021

Removed the upperbound for numpy.
numpy>=1.20 only works with pyspark>=3.1, so show a warning when numpy>=1.20 with pyspark<3.1 together.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #2166 (3ffc2de) into master (46c80e6) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 3ffc2de differs from pull request most recent head 873795b. Consider uploading reports for the commit 873795b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2166      +/-   ##
==========================================
- Coverage   95.36%   95.34%   -0.02%     
==========================================
  Files          60       60              
  Lines       13707    13711       +4     
==========================================
+ Hits        13071    13073       +2     
- Misses        636      638       +2     
Impacted Files Coverage Δ
databricks/koalas/__init__.py 89.02% <50.00%> (-2.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c80e6...873795b. Read the comment docs.

@ueshin ueshin marked this pull request as ready for review June 9, 2021 01:56
@ueshin
Copy link
Collaborator Author

ueshin commented Jun 9, 2021

Thanks! merging.

@ueshin ueshin merged commit ee07248 into databricks:master Jun 9, 2021
@ueshin ueshin deleted the numpy branch June 9, 2021 03:15
@HyukjinKwon
Copy link
Member

@ueshin shall we remove the upperbound in OSS spark too? https://github.com/apache/spark/blob/master/python/setup.py#L272

@ueshin
Copy link
Collaborator Author

ueshin commented Jun 14, 2021

Yes, sounds good. I'll submit a PR soon.

@ueshin
Copy link
Collaborator Author

ueshin commented Jun 14, 2021

FYI: apache/spark#32908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants