Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DataFrame.first and Series.first functionality #2128

Merged
merged 5 commits into from
Mar 31, 2021
Merged

Implement DataFrame.first and Series.first functionality #2128

merged 5 commits into from
Mar 31, 2021
+133 −18

Conversation

awdavidson
Copy link
Contributor

Please see change to implement DataFrame.first and Series.first functionality similar to that available in pandas. Requirement raised in issue: #1929

>>> index = pd.date_range('2018-04-09', periods=4, freq='2D')
>>> ks_series = ks.Series([1, 2, 3, 4], index=index)
2018-04-09  1
2018-04-11  2
2018-04-13  3
2018-04-15  4
dtype: int64

>>> ks_series.first('3D')
2018-04-09  1
2018-04-11  2
dtype: int64

ueshin
ueshin reviewed Mar 31, 2021
View reviewed changes
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awdavidson Thanks for working on this!
I left some comments. Could you address them? Thanks!

databricks/koalas/frame.py Show resolved Hide resolved
databricks/koalas/tests/test_series.py Outdated Show resolved Hide resolved
@awdavidson
Copy link
Contributor Author

@awdavidson Thanks for working on this!
I left some comments. Could you address them? Thanks!

No problem, comments have been addressed. Thanks! :)

@awdavidson awdavidson requested a review from ueshin March 31, 2021 19:27
ueshin
ueshin approved these changes Mar 31, 2021
View reviewed changes
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending tests.

@ueshin
Copy link
Collaborator

ueshin commented Mar 31, 2021

Thanks! merging.

@ueshin ueshin merged commit 0565e14 into databricks:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueshin ueshin ueshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awdavidson @ueshin